PlaneShift

Development => Development Deliberation => Topic started by: Ezrec on March 05, 2006, 07:57:39 pm

Title: Bugfix: paws editor widgets & const iterator
Post by: Ezrec on March 05, 2006, 07:57:39 pm

First: Iterator class was used where ConstIterator is required
Second: Make hard-coded filenames match actual filenames in CVS for PAWS GUI widgets


Index: src/server/progressionmanager.cpp
===================================================================
RCS file: /cvsroot/planeshift/planeshift/src/server/progressionmanager.cpp,v
retrieving revision 1.204
diff -d -u -p -r1.204 progressionmanager.cpp
--- src/server/progressionmanager.cpp   1 Mar 2006 18:27:50 -0000       1.204
+++ src/server/progressionmanager.cpp   5 Mar 2006 18:53:24 -0000
@@ -2922,7 +2922,7 @@ csString ProgressionEvent::ToString(bool
 {
     csString xml;
     if (topLevel) xml.Append(\"\");
-    csArray::Iterator seq = sequence.GetIterator();
+    csArray::ConstIterator seq = sequence.GetIterator();
     while (seq.HasNext())
     {
         ProgressionOperation * po = seq.Next();
Index: src/tools/pawseditor/pawseditorapp.cpp
===================================================================
RCS file: /cvsroot/planeshift/planeshift/src/tools/pawseditor/pawseditorapp.cpp,v
retrieving revision 1.18
diff -d -u -p -r1.18 pawseditorapp.cpp
--- src/tools/pawseditor/pawseditorapp.cpp      3 Feb 2006 23:00:59 -0000      1.18
+++ src/tools/pawseditor/pawseditorapp.cpp      5 Mar 2006 18:53:24 -0000
@@ -450,9 +450,9 @@ bool PawsEditorApp::LoadWidgets()
 {
     bool succeeded = true;
 
-    succeeded &= LoadWidget(\"data/pawseditor/peWidgetTree.xml\");
-    succeeded &= LoadWidget(\"data/pawseditor/peMenu.xml\");
-    succeeded &= LoadWidget(\"data/pawseditor/peSkinSelector.xml\");
+    succeeded &= LoadWidget(\"data/pawseditor/pewidgettree.xml\");
+    succeeded &= LoadWidget(\"data/pawseditor/pemenu.xml\");
+    succeeded &= LoadWidget(\"data/pawseditor/peskinselector.xml\");
 
     return succeeded;
 }

Title:
Post by: DaveG on March 05, 2006, 09:17:02 pm

The first is known, and is only not in CVS because we\'re not officially using latest CS yet.  You should probably be using something around the 18th.  (dates are always listed in the topic of #planeshift-build on FreeNode)

The second one... No one has futzed with that in a while.  I just edit the XML manually.  ;)  Is it case-sensitive for you?  The app loads up just fine for me.

Title:
Post by: Ezrec on March 06, 2006, 01:49:59 am

I run Linux AMD x86_64, so, yes, it is case sensitive.

I\'m currently trying to make everything (including crystalspace) \"clean\" for GCC 4.x

Wish me luck,

Title:
Post by: ThomPhoenix on March 06, 2006, 06:13:10 pm

Good luck!  :)

Title:
Post by: Ezrec on March 06, 2006, 07:01:18 pm

Thanks!

I got it working on a Mandriva 2006.0 system with:

gcc 4.0.1
CS head, CEL head, CAL3D head, PS head

.. and a buttload of patches...

But I now have a little dwarf running around playing with
an oven and beating up on NPCs.


So, is there any need for a quest writer?

Title:
Post by: DaveG on March 06, 2006, 08:19:27 pm

Quote

Originally posted by Ezrec
So, is there any need for a quest writer?

Yes, actually.  We\'re trying out a new application form:
http://laanx.fragnetics.com/nexus/newapplicant.php

Please fill the whole thing out, if you want to apply.  Be warned that people who are leaving everything blank (or putting in junk) are obviously not likely to be considered.

Title:
Post by: Ezrec on March 06, 2006, 10:44:35 pm

Hmm. Unfortunately my \'portfolio\' is a little thin right now with respect to \'Writing Quests\'.

So I guess I\'ll just have to populate my private PlaneShift server with a whole bunch \'o quests, test them, and have *that* as my portfolio.

I would guess a working example would beat me prattling on all day, eh?

First, a little research on who the current NPC are...

/me gets busy...

Title:
Post by: DaveG on March 06, 2006, 11:21:31 pm

Quote

Originally posted by Ezrec
Hmm. Unfortunately my \'portfolio\' is a little thin right now with respect to \'Writing Quests\'.

So I guess I\'ll just have to populate my private PlaneShift server with a whole bunch \'o quests, test them, and have *that* as my portfolio.

That\'s the spirit.  :)