PlaneShift
Development => Development Deliberation => Topic started by: talentraspel on December 31, 2006, 10:27:28 am
-
Hi.
I noted that in the production version 0.3.017 the max capacity is displayed as 750 wich is read internally as hardcoded value from a calculation script. In the CVS version (even HEAD, as of 31.12.06) the max capacity is displayed as 0. I digged down into the code and found that the value for max capacity is not transferred with the inventory message. So I wonder how it works in production. Is there some code still waiting to be checked in? I also miss the TAG for 0.3.17 in CVS. Is CVS really up to date with production version 0.3.17?
Suggested fix for the problem, based on CVS:
In my opinion the inventory message has to be extended for the max capacity value as it it already done for the max weight value. The field field for displaying its value in the GUI is already there. But it would be better to check why it works in production. Perhaps it is a problem with setting up PS.
Regards,
Kai.
-
This is perhaps the only case where lag does something useful ;)
Max capacity is sent in the MSGTYPE_STATS message, which in case of your own server arrives just few milliseconds too early and the inventory window is not yet created to show it.
-
Shouldn't we then move the value for max capacity to the inventory-message? The other values that are transferred with it are timed correctly. I would also make more sense to transfer all values for the inventory with one single message. It looks like me that the stats message is a bit misused in thi case and only used because it already exists for an other purpose.
Regards,
Kai.