PlaneShift

Development => Development Deliberation => Topic started by: Gellule on May 05, 2004, 07:29:46 am

Title: Current CVS psengine.cpp compilation fail under mingw32
Post by: Gellule on May 05, 2004, 07:29:46 am

Compilation output:

C++ ./out/msysx86/debug/src/client/psengine.o
src/client/psengine.cpp: In member function `iMaterialWrapper*
   psEngine::LoadMaterial(const char*, const char*)\':
src/client/psengine.cpp:988: no matching function for call to `iLoader::
   LoadImageA(const char*&, int)\'

It seems that the #undef LoadImage work around in the first few lines of psengine.cpp (OS specific defines) does not work with me. It looks like there is a LoadImage->LoadImageA defined in one of the following included headers.

I traced down this definition as coming from both:
#include \"globals.h\"
#include \"psengine.h\"

Would it be a good solution to move the OS specific defines after the headers inclusions?

-Gellule

Title:
Post by: dfryer on May 05, 2004, 08:42:33 am

Someone on IRC had this problem, I believe, and it was fixed by either forcing the block involving the #undef, or moving it above (or maybe below) some headers...  To summarize, I don\'t know what I\'m talking about but I seen it before!

Title:
Post by: Gellule on May 05, 2004, 08:57:48 am

Thanks! That\'s exactly what I did. Move the #undef below the #include.

Beside that, when you find this kind of problem is posting here the best thing to do? Can you do more and propose a modification of code?

Other question: how well is the mingw32 build suported? Is it possible to help with it?

-Gellule

Title:
Post by: acraig on May 05, 2004, 04:27:10 pm

I believe that Jorrit ( the head of Crystal Space project ) uses mingw32 to build.  He is the only person that I know that uses it so it is supported but just not very well.  I will place any fixes that you have that can make the compile better for mingw32.

Posting here is good ( why this forum was created ) or contacting us on irc ( irc.freenode.net in #planeshift )  or contact me directly ( acraig@planeshift.it ) directly with any patches.

Title:
Post by: Gellule on May 05, 2004, 09:07:14 pm

Then, what\'s the most convenient way to submit a patch?
Any tool I should use?

Title:
Post by: Gellule on May 05, 2004, 09:36:10 pm

I think I found: I sent you an E-mail with the diff log.

I\'d like to send another one on compiling-mingw.txt. Should I go ahead ?

-Gellule