Show Posts

1

Development Deliberation / Re: Subject: Fix segfault when opening 'Skills and stats' window

« on: January 12, 2012, 06:53:20 pm »

I'm not a prospect, this is not for the 'Dev's' (who don't accept patches anyway).
This is here for those that compile their own, and are not on #Planeshift-build when I am...

2

Development Deliberation / Subject: Fix segfault when opening 'Skills and stats' window

« on: January 12, 2012, 05:30:41 pm »

Move message subscription to the end of window post-initialisation.
If a message arrives before post-initialisation has completed, access
to uninitialised variables can occur, causing a segfault.
Make message subscription the very last action.

---
trunk/src/client/gui/pawsskillwindow.cpp | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/trunk/src/client/gui/pawsskillwindow.cpp b/trunk/src/client/gui/pawsskillwindow.cpp
index 6f0f089..e47bdaf 100644
--- a/trunk/src/client/gui/pawsskillwindow.cpp
+++ b/trunk/src/client/gui/pawsskillwindow.cpp
@@ -93,8 +93,6 @@ bool pawsSkillWindow::PostSetup()
{
return false;
}
- psengine->GetMsgHandler()->Subscribe(this, MSGTYPE_GUISKILL);
- psengine->GetMsgHandler()->Subscribe(this, MSGTYPE_FACTION_INFO);

xml = csQueryRegistry<iDocumentSystem > ( PawsManager::GetSingleton().GetObjectRegistry());

@@ -143,6 +141,9 @@ bool pawsSkillWindow::PostSetup()
currentTab =0;
previousTab =0;

+ psengine->GetMsgHandler()->Subscribe(this, MSGTYPE_GUISKILL);
+ psengine->GetMsgHandler()->Subscribe(this, MSGTYPE_FACTION_INFO);
+
return true;
}

3

Development Deliberation / Subject: Fix segfault when opening NPC dialog

« on: January 12, 2012, 05:28:52 pm »

NPC dialog causes a segfault by usage of variables which have not
previously been initialised because of failed widgets (Lists,Bubbles).
Check the variables before attempting use.

---
trunk/src/client/gui/pawsnpcdialog.cpp | 20 ++++++++++++--------
1 files changed, 12 insertions(+), 8 deletions(-)

diff --git a/trunk/src/client/gui/pawsnpcdialog.cpp b/trunk/src/client/gui/pawsnpcdialog.cpp
index de5c7dc..be78a6e 100644
--- a/trunk/src/client/gui/pawsnpcdialog.cpp
+++ b/trunk/src/client/gui/pawsnpcdialog.cpp
@@ -522,20 +522,24 @@ void pawsNpcDialogWindow::SetupWindowWidgets()
if(border) border->Hide();
//if(close_widget) close_widget->Hide();
if(lists) lists->Hide();
- if(bubbles) bubbles->Show();
- defaultFrame = bubbles->DefaultFrame();
- Resize();
- SetSize(defaultFrame.Width(), defaultFrame.Height());
- MoveTo(0,0);
+ if(bubbles) {
+ bubbles->Show();
+ defaultFrame = bubbles->DefaultFrame();
+ Resize();
+ SetSize(defaultFrame.Width(), defaultFrame.Height());
+ MoveTo(0,0);
+ }
}
else
{
if(border) border->Show();
if(close_widget) close_widget->Show();
- if(lists) lists->Show();
if(bubbles) bubbles->Hide();
- defaultFrame = lists->DefaultFrame();
- Resize();
+ if(lists) {
+ lists->Show();
+ defaultFrame = lists->DefaultFrame();
+ Resize();
+ }
}
}

4

Development Deliberation / Re: Not seeing my model

« on: June 26, 2010, 01:13:28 am »

A little information to go on would be useful.......
But if you are using Linux and a Radeon GPU you will need to install proprietary drivers

5

Development Deliberation / Fix for CS_ASSERT failure include/csutil/array.h line 670

« on: June 25, 2010, 08:32:07 pm »

Fix for CS_ASSERT failure include/csutil/array.h line 670
Repository Root: https://planeshift.svn.sourceforge.net/svnroot/planeshift
Revision: 5995
diff --git a/src/common/bgloader/loader.cpp b/src/common/bgloader/loader.cpp
index fffd927..bd735c4 100644
--- a/src/common/bgloader/loader.cpp
+++ b/src/common/bgloader/loader.cpp
@@ -242,6 +242,7 @@ void BgLoader::ContinueLoading(bool waiting)
finished = true;
finalisableMeshes.Push(loadingMeshes[loadingOffset]);
loadingMeshes.DeleteIndex(loadingOffset);
+ --endOffset;
}
}

6

Development Deliberation / Coding mistakes slipped through

« on: December 04, 2008, 11:59:24 pm »