PlaneShift

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bug Report
  • Category
  • Assigned To
    Kenneth Graunke
  • Operating System
  • Severity Low
  • Priority
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: PlaneShift
Opened by Caarrie - 01.01.2008
Last edited by Lanarel - 04.01.2008

FS#888 - Doll view in stats window uses the wrong camera distance

The doll view in the stats window has a different camera distance and does not remain the same at different resolutions—at some it is too close, at others too far.

I believe that changing line 110 of skillwindow.xml to " <distance value=”2.5”/>” should fix the issue.

Closed by  Lanarel
04.01.2008 21:59
Reason for closing:  
Additional comments about closing:  

Looks like it used to.

Arianna commented on 02.01.2008 08:21

Question: why is this a feature request and not a bug report? Wasn't it due to the changes in some part of the code?
I recall a bug report on this?

Caarrie commented on 02.01.2008 11:54

yes it was due to a bug, but it is not something we cant live without, [you can still see the doll and all is fine there]

Arianna commented on 02.01.2008 13:16

I still think something like this should be a bug report and not a feature request. It is nothing "new", it is just to make things more "usable".
Well, it is not the end of the world if it is one thing or another, but I think when we have problems on how things are display those are bugs rather then features. Imho!

Arianna commented on 03.01.2008 08:24

Assigning to Kayden.

Kenneth Graunke commented on 03.01.2008 11:21

I tested this fix at several resolutions (both 8:5 and 4:3) and found that it did not work correctly.

The issue was two-fold: the scaling factor in pawsobjectview.cpp was incorrect (so adjusting the value for one resolution would make it wrong for another), and scaling was being applied even if the widget was already resized—double scaling.

Fixed in SVN.

Caarrie commented on 03.01.2008 11:23

what happened to testers testing and closing the bugs and not devs???

Arianna commented on 03.01.2008 14:03

Reopen for verification. I think the changes were minor but maybe it is better to test them on different systems/resolutions (even though I believe that Kayden did at least the test on different resolutions)

Kenneth Graunke commented on 03.01.2008 18:46

If this is to be handled as an actual bug report, then I may as well make it look like one.

Project Manager
Lanarel commented on 04.01.2008 21:59

Looks good, re-closing :)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing