PlaneShift

/killnpc PID: 13 works fine for me on my local server with no modification of the source, please retest and include the space after PID:

Hmm, this gets tricky when you do something like "/killnpc Rogue"… there are many NPCs with that name.

Just tested on Laanx PID: with and without space fails. "No NPC was targeted."

The reason I mention name is that the help file says name does work. This isn't really something we would be chasing down multi-spawn NPC's with - but for fixing important NPC's who fall off of the map to hard to target spots since.

Confirming. It doesn't work with EID at all, and the PID syntax suffers from an off-by-one error making it fail 100% of the time.

Making it work with a name is probably still useful if, say, you need to reboot Finra or something.

Fixed in trunk and stable (r1337).

Nice work, you made it so the name works ;) but on the other hand…

now using the "pid: #" format crashes the server, reproduced twice:

Core was generated by `./psserver –run=/this/loadbasic'.
Program terminated with signal 11, Segmentation fault.
#0 0x00002aeff0a37c2c in ?? () from /lib/libc.so.6
(gdb) bt
#0 0x00002aeff0a37c2c in ?? () from /lib/libc.so.6
#1 0x000000000047da5d in AdminManager::KillNPC (this=<value optimized out>, me=0x268af40, msg=<value optimized out>, data=@0x41000130,

  client=0x26528c0) at /usr/include/gentoo-multilib/amd64/stdlib.h:336

#2 0x0000000000499b7a in AdminManager::HandleAdminCmdMessage (this=0xc4d7e0, me=0x268af40, msg=@0x41000e20, data=@0x41000130, client=0x26528c0)

  at src/server/adminmanager.cpp:1041

#3 0x000000000049b53f in AdminManager::HandleMessage (this=0xc4d7e0, me=0x268af40, client=0x26528c0) at src/server/adminmanager.cpp:144
#4 0x000000000068cf85 in MsgHandler::Publish (this=0xc041c0, me=0x268af40) at src/common/net/msghandler.cpp:93
#5 0x0000000000756bb2 in EventManager::Run (this=0xc041c0) at src/common/util/eventmanager.cpp:171
#6 0x00000000005a346d in CS::Threading::Implementation::(anonymous namespace)::proxyFunc (param=0x7fffbb0871b0)

  at libs/csutil/threading/pthread_thread.cpp:75

#7 0x00002aefefc42047 in start_thread () from /lib/libpthread.so.0
#8 0x00002aeff0ac428d in clone () from /lib/libc.so.6
#9 0x0000000000000000 in ?? ()
(gdb) bt full
#0 0x00002aeff0a37c2c in ?? () from /lib/libc.so.6
No symbol table info available.
#1 0x000000000047da5d in AdminManager::KillNPC (this=<value optimized out>, me=0x268af40, msg=<value optimized out>, data=@0x41000130,

  client=0x26528c0) at /usr/include/gentoo-multilib/amd64/stdlib.h:336
      obj = <value optimized out>
      target = <value optimized out>
      p = <value optimized out>

#2 0x0000000000499b7a in AdminManager::HandleAdminCmdMessage (this=0xc4d7e0, me=0x268af40, msg=@0x41000e20, data=@0x41000130, client=0x26528c0)

  at src/server/adminmanager.cpp:1041
      targetobject = (class gemObject *) 0x0
      targetactor = (class gemActor *) 0x0
      targetclient = (Client *) 0x0
      targetID = <value optimized out>
      p = <value optimized out>
      p = <value optimized out>

Blimey. Sorry, I'll fix it later today.

By the way, "pid: #" is erroneous syntax and actually never worked in the first place…Caarrie must have had the NPC targeted when testing.

Fixed the crash in r1342. Again, "pid: #" is wrong and won't work…use "pid:#".