- Status Closed
- Percent Complete
- Task Type Bug Report
- Category Engine
- Assigned To No-one
- Operating System
- Severity Low
- Priority
- Reported Version
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
Attached to Project: PlaneShift
Opened by Andrei Ristea - 17.10.2008
Last edited by Anonymous Submitter - 15.07.2009
Opened by Andrei Ristea - 17.10.2008
Last edited by Anonymous Submitter - 15.07.2009
FS#2385 - Inability to remove NPC from buddy list
The current behaviour is not to be able to add NPC’s to buddy list.
Although some NPC’s cannot be added anymore, for example “Jomed Parcen”, or “Harnquist”, some of them can.
I tried with Aleena Alarvin and Amidison Stronghand. I managed to add the from the buddy list menu, simply by using their first names, just as for players. They cannot be removed anymore.
Closed by Anonymous Submitter
15.07.2009 14:17
Reason for closing:
15.07.2009 14:17
Reason for closing:
True.
so is this a bug or did i miss something when testing
bug 2380?? I tried to add an npc to my buddy list on the test server and was unable, so i manually added one on my localserver in the db and then i was able to remove them successfully by using the "remove" button after having selected the npc to remove.It is linked to that bug indeed. It works with some NPC's, it doesn't with others. Not sure why yet, but on the main server, if you try with Amidison, the bug is repeatable.
This may not be a bug. GM's and other dev's make player characters for events with the same name as an NPC to play a role. If such characters are kept for a time, such as for a series of events, they can be added to your buddy list, just as any other player. You haven't added the NPC to your buddy list…you've added a temporary player character held by a GM or dev. There's no way in game to tell the difference. When the event or series is over, the temp character is deleted and will disappear from the buddy list.
That sounds plausible.
Ralleyon, do you think you might have added those npcs when they were taken over by a GM?
That is plausible indeed, but I am pretty sure (80% if I have to give an estimate) they were not taken at the time.
The issue is not being able to add them really, but the impossibility to remove them.
Inability to remove is a a differnet issue, and the title of this report should perhaps be changed. Perhaps the remove code is not using PID as it should, using name instead, leading to a conflict when it finds the name to belong to an NPC.
Would have to be an Engine issue.
Buddy list actions are not allowed on npc. Something like the following would keep the current no npc allowed for add and toggle while allowing npc for remove.
http://pastebin.ca/1468707
Strangely enough the problem sorted itself out.
I can not seem to add any of the problematic NPC's anymore, nor do they show up in my buddy list. The only exception is Aleena (at this time), which is used by a player character from a while back as well. Amidison is now fine.
By current I mean with client PS 0.4.03 and current Laanx server build.