FS#3156 - New elves skin desription window does not show whole buttons
In the description window, the buttons are only partly visible. They may just miss a heigh attribute in the xml file, as I saw a similar fix elsewere.
Assigning to Venge and Cherppow, but this can probably be fixed by someone else too.
committed a fix
Height is OK now. Is there also a width attribute? Will check myself in a minute.
Patch to adjust the widths as well:
http://tinyurl.com/m2zgjq
Assigned to weltall to commit it as he looked at this before, but someone else can do so as well.
it looks a bit badly maybe you can improve it in order to mantain the style wanted by the artist?
Can you explain where my changes fail to meet the style wanted by the artist? The examples I had of that style were buttons with half the text visible. My changes make the text visible, while ordering the buttons a bit so they fit. If you mean actually use the elves style, I will leave that to the artist. My patch just makes the skin more useable :)
Better like this?
http://pastebin.ca/1557785
1) same size buttons. THe description one looks extremely wrong and not only for the abnormus size on the rest
2) little additional space on the border this is ignored on the right
the addition looka a bit better
1) I take it the desc one is pressed when you open the window, hence why its size is smaller.
2) Not sure what you mean…
Ok, new patch http://filebin.ca/brzbd
Patch commited by Weltall in rev 4335.
In the original window, the description button was called Descr and the Combat and some other buttons were to small for their text. I prefer buttons of the same size too, but the window is too small to fit them. If you find a better way to organize the buttons thats great. Cannot check what the new patches look like, but I am glad I made someone have a look at this anyway :)