- Status New
- Percent Complete
- Task Type Feature Request
- Category Engine
-
Assigned To
Joe Lyon - Operating System
- Severity Medium
- Priority
- Reported Version
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
FS#6138 - sort storage on name, type, value etc.
Sometimes I would which i could sort the storage list in a different way. Would it be possible to add bi-directional sort options in the storage/buy window?
It is easy enough to add column headers to the windows to allow sorting, it is just an XML option. But. Value is sent to the client as a string not a number so when you sort it does not sort as expected, I already tried doing this. If this can be changed then adding column headers to allow sorting would be worth doing.
Here is a patch for sorting after count, price and name: http://pastebin.com/svw8RLQU.
(It's just a pullout of PSExtended, so check first, if it's working)
The funny thing is, that there was everything in the code already, you just had to activate it ;)
I think you know how to update the xml parts, but you should disable sorting by images (sortable="no"), because the code is not written for that.
Thanks neeno, I tested the patch and it seems to be ok. I think we will work on adding it, thanks for all your code we've been adding small pieces one at a time.
I just checked this in. Thanks Neeno and Venalan!
We will need to add a flag to indicate if the column is numeric data, since it presently sorts as strings. I'll do that asap if you don't beat me to it. ;)
At present this is just implemented in the merchant window. there's a related ticket that requests sorting by quality in the storage window.
I remember, when Neeno added this to PSExtended, he had to do a small modification in order to support numerical sorting, which works perfectly fine with his mod package.
Small issue: When accidentally double-clicking on the headings, the item details window pops up.
I'll move that bug to another post Evaraj.