PlaneShift

Confirmed, it annoyed me too the other day. It shouldn't be possible to have a key assigned to two different functions.

This is very similar, if not a duplicate of  FS#1306 .

Assigning Boite per request.

I first said "it shouldn't be possible to have a key assigned to two different functions", but middle-click is a handy trigger for mouselook. Perhaps it could be made so that you *can* have mouselook assigned to middle-click, but that it does not trigger when you use middle-click on an item in your inventory (take whole stack). So besides just an input check, also a context check.

I did not know about the shortcut to pick up a whole stack! I would have found this very useful on a thousand ocassions. However, I also use middle-click for toggling mouse-look, so it wouldn't work for me anyway. :p

Boite where is the patch? please upload to pastebin.ca

Qia Fask: you may be interested to know, holding control and clicking a stack takes the whole stack, holding shift and clicking the stack takes one item.

Patch for  FS#1336  add a check for know if mouselook are use on the psmainwidget (let use mouseLook just when click on the psmainwidget), add new options entries for bind the mouse with drag,drag all stack& drag just one.

http://boite.pastebin.ca/1050321

Version 0.4.01 suffers this problem. I just noticed while smelting platinum.
When I pick up several units using MiddleClick the mouse pointer moves to the center of the screen and gets stuck there (MouseLook gets toggled).

My MiddleClick is bound to MouseLook (which I believe is by default).

(Hint: TAB key releases MouseLook and the mouse pointer)

Committed to trunk (r1872), thanks Boite

setting back in progress as if no shortcuts are set in the default xml new and old players alike that dont know that this feature has to be set will be totally lost. also there should be a way to make sure that people that already have a mouse.xml file dont have to reload their options to get this to work.

Also… the "toggle mouselook" key didn't seem to work anymore, whether it was tab or another key… and the ctrl, shift and alt click modifiers don't seem to work on stacks anymore. It was my preferred way of taking the whole stack, and it is probably needed for mac users with one button mice.

In case you didn't know, control-leftclick took the whole stack, and shift-leftclick took one off the top. The problem with your latest patch is that you can only assign mouse buttons by themselves to these functions, and I only have a three button mouse… so if I bind leftclick to normal drag, middle click to drag all items, I have no button for drag one item, as right click is used for "examine" or "context menu", which overrides it.

this patch was applied on the stable branch and now I'm unable to drag anything from the inventory i had to revert this back on my client to be able to use it again correctly: could someone revert it in stable as this seems to have still some glitches?

To get it to work, set the buttons in the mouse options window. My only problem with it as it is now, is that with a three button mouse you can't have all the functions bound, including the default right click for item description.

The problem is that the required gui xml (configmouse.xml) to do that is missing from the stable branch and from the data folder of the official client. So you can't change the options at all without getting the file from the trunk and putting it in the data folder manually.

this is only an issue if you build stable, this patch was done after the release so it does not affect the players with the official client.

It seems this patch introduces a warning from the compiler:

C++ ./out/linuxx86/debug/src/client/gui/psmainwidget.o
src/client/gui/psmainwidget.cpp: In member function ‘virtual bool psMainWidget::OnMouseDown(int, int, int, int)’:
src/client/gui/psmainwidget.cpp:358: warning: comparison between signed and unsigned integer expressions
src/client/gui/psmainwidget.cpp:358: warning: comparison between signed and unsigned integer expressions

(it's about line 58 in the patch posted above : if(mouseLookTrigger→button==button && mouseLookTrigger→mods==keyModifier))

yup just need a variable cast for that
if(mouseLookTrigger→button==(uint)button && mouseLookTrigger→mods==(uint)keyModifier))

http://boite.pastebin.ca/1078604

I can't use mouselook at all now, pressing tab just doesn't do anything, the mouse doesn't disappear. Mouselook can't be enabled at all. What's going on, is it this patch?

Raising priority, since stuff is clearly broken.

http://peg.psde.de/planeshift/fs1336_r3.diff

This patch should fix all remaining issues:
- broken mouse look toggle
- incomplete default configuration
- incompatibility with old configuration files

Tested by ThomPhoenix and myself.

Committed in trunk r2036, thanks.