PlaneShift

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bug Report
  • Category
  • Assigned To
    Mike Gist
  • Operating System
  • Severity High
  • Priority
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: PlaneShift
Opened by Caarrie - 31.05.2008
Last edited by Mike Gist - 02.06.2008

FS#1635 - psupdater fails to run correctly

when running psupdater it starts to update renames updaterinfo.xml to updaterinfo.xml.bak then stops, on the next attempt to run the updater you are unable to as it cant find updaterinfo.xml but it only tells the user that it cant find the root node in the file. I am not sure what is going on this is with what i think is the most updated psupdater there is in svn
./psupdater
PlaneShift Updater Version 5 for linux32.

Checking for updates:
./psupdater
PlaneShift Updater Version 5 for linux32.

Checking for updates:
Couldn't open xml file '/this/updaterinfo.xml'!
Unable to get root node
SCF WARNING: 1 unreleased instances of class crystalspace.kernel.vfs!

Closed by  Mike Gist
02.06.2008 20:35
Reason for closing:  
Additional comments about closing:  

Closing, I'm pretty sure it's fixed.

Mike Gist commented on 31.05.2008 23:49

I'll need to know the output of the 'stopped' update. The updater has code to handle this which I'm pretty sure works correctly.

Caarrie commented on 01.06.2008 00:25

that is all that i see nothing more nothing less

Mario Rohkrämer commented on 01.06.2008 06:17

Xordan means the output of the first update where the updaterinfo.xml got renamed to updaterinfo.xml.bak, but not back again.

Or do all updater calls now forget to rename the file back or create a new version, no matter how successful the update was?

Steven Schwartfeger commented on 01.06.2008 10:15

http://www.pastebin.ca/1035739

Mike Gist commented on 01.06.2008 17:22

I've fixed that crash to fail cleanly instead. It's supposed to fail in that case, so not a bug.

Caarrie commented on 01.06.2008 18:57

now it fails cleanly but still does not restore the updaterinfo.xml file

Mike Gist commented on 01.06.2008 19:00

Yes it does. Try again.

Caarrie commented on 01.06.2008 19:17

./psupdater
PlaneShift Updater Version 5 for linux32.

Checking for updates:

./psupdater
PlaneShift Updater Version 5 for linux32.

Checking for updates:
Couldn't open xml file '/this/updaterinfo.xml'!
Unable to get root node
SCF WARNING: 1 unreleased instances of class crystalspace.kernel.vfs!

Mike Gist commented on 02.06.2008 19:00

Okay, I've tested it myself and fixed a few bugs. It should work fine now :)

Thom commented on 02.06.2008 20:13

I just got this:

PlaneShift Updater Version 5 for win32.

Checking for updates:
This updaterinfo.xml file is marked as inactive and will not work. Please get an
other one.
SCF WARNING: 1 unreleased instances of class crystalspace.kernel.vfs!

Updater finished, press enter to exit.

edit: will retest with latest code
edit2: still happening.

Mike Gist commented on 02.06.2008 20:18

Looks fine to me :)

Thom commented on 02.06.2008 20:21

That's fine? Okay then.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing