PlaneShift

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bug Report
  • Category
  • Assigned To No-one
  • Operating System
  • Severity Medium
  • Priority
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: PlaneShift
Opened by Johannes Tausch - 25.06.2008
Last edited by Mario Rohkrämer - 17.10.2009

FS#1753 - Unexpected (wrong) system message while mining

You probably should not leave 1 Iron Ingot here.
or:
You probably should not leave 7 Roots of Jarana here.
and similar system messages may appear while mining even if you did not leave anything there. I asked in the help channel about and received the answer this is a known bug. For I did not find any bug report about this, I report now.
Yours,
tux_johny

The task depends upon
ID Project Summary Priority Severity Assigned To Progress
2517 PlaneShift  FS#2517 - Odd item/container message while mining  Low
100%
2625 PlaneShift  FS#2625 - "You should not leave" messages while mining  Very Low
100%
2657 PlaneShift  FS#2657 - Msg from psWorkManager::HandleCleanupEvent()  Medium
100%
The task blocks this from closing
ID Project Summary Priority Severity Assigned To Progress
2656 PlaneShift FS#2656 - list of crafting bugs Low Davide Vescovini, Tuathanach
0%
Closed by  Mario Rohkrämer
17.10.2009 11:12
Reason for closing:  
Additional comments about closing:  

Reopened with a different issue - so closing again.

Steven Schwartfeger commented on 03.07.2008 08:59

I kinda suspect this is the same as the dwarf bug,  FS#1834  among others… but since I know this particular bug has been around much longer, since the 0.4 release, I don’t know…

Steven Schwartfeger commented on 08.07.2008 08:10

OK, I verified with svn trunk. I did some crafting tests, then left some ingredients in the wooden bowl; a good while later I get the message “You probably should not leave 1 Milk here.” I had left a stack of 1 milk in the bowl, among other things.

Shorina commented on 09.07.2008 10:00

I got “You probably should not leave 1 GOLD [ore/ingot, can’t remember exactly] here” when the game must have decided I was too slow in removing my IRON INGOTS from the stock casting at Harnquist’s. I wasn’t even particularly slow. I made 10 iron ingots and had removed 7 from the stock casting by the time I got that message for each of the remaining 3 ingots.

Johannes Tausch commented on 13.07.2008 11:22

This bug report in not on melting at the furnance, but on mining! “You probably should not leave…!” occurs from time to time while mining. It does not depend on what was left anywhere the last 10 times logged in at least, because I got the “molten steel” message today. I did not do anything with steel for a very long time now. At least not with the new client 0.4.01. The character “Tomislav” (Klyros) agreed to the character “Zzurlosch” (dwarf) at the platinum mine, that this message happens from time to time to him, too. So it has nothing to do with any dwarfen bug.

James commented on 22.08.2008 01:10

(09:04:34) >You start to dig.
(09:04:34) >You probably should not leave 28 Water Pouch here.
(09:04:35) >You probably should not leave 28 Water Pouch here.

Followed 10 seconds later by the usual mining failed message
(09:04:44) >You gained a little experience
(09:04:44) >You were not successful.

Male enki at the oja gold mine. The last crafting I did was 16 days ago.

Project Manager
Lanarel commented on 22.08.2008 22:08

Although the system providing a massage when you get tired from mining sounds nice, it is not what this is about, so I will correct the typo in the title :)
Tux: the remark about the dwarf bug was not to mean that this has to do with dwarves, but that it has similarities to the bug where other characters would just appear behind you. In this case, it sounds that you get messages intended for someone else.
Slightly increasing priority too.

Elvors Amenoras commented on 29.12.2008 01:20

Confirming for a Menki, on several occasions, but very, very rarely. Here are some of the messages I got or heard of over time:

* You probably should not leave an apple here
* You probably should not leave 40 pinch of Salt here
* You probably should not leave 1 Dresses of Queen Purrty (2) here
* You probably should not leave 19 Macca here

I’m absolutely sure I never owned a Dress of Queen Purrty, so the item mentioned in the message is probably entirely random.

Hitman commented on 30.12.2008 00:07

I have received the following messages while mining:

“You probably should not leave 1 Owl’s Broad Sword here.” 2008-12-29 23:35 GMT
“You probably should not leave 1 Sapphire-encrusted Dagger here.” 2008-02-02 00:15 GMT
“You probably should not leave 1 Tefusang skin here.” 2009-02-02 02:08 GMT

They occured at completely different mines, and immediately after calling a /dig command; the mining process continued as usual.

I have a slight hunch that somewhere else in the world a different character actually tried putting the items being mentioned into a container (sack or box) and failed. This is because most of them are relatively large or numerous items that would take up a lot of space in containers.

Hiker Hauk commented on 06.01.2009 13:59

Svn diff format per Caarrie’s request.

I diffed with the stable trunk. For the record I’m not an official PS dev and do not know which revision I should compare with.
This is just a theory and without official setting database it’s hard to test. But the change won’t bring side effect I think.

Index: workmanager.cpp
===================================================================
--- workmanager.cpp	(revision 2795)
+++ workmanager.cpp	(working copy)
@@ -3929,7 +3929,9 @@
         cleanItem->SetGuardingCharacterID(0);
         cleanItem->Save(true);
         cleanItem->SetTransformationEvent(NULL);
-        psserver->SendSystemOK(clientNum,"You probably should not leave %d %s here.", cleanItem->GetStackCount(), cleanItem->GetName());
+        //psserver->SendSystemOK(clientNum,"You probably should not leave %d %s here.", cleanItem->GetStackCount(), cleanItem->GetName());
+        // Hiker Hauk 20090106: Gets client num from the work event instead of from member variable
+        psserver->SendSystemOK(workEvent->client->GetClientNum(),"You probably should not leave %d %s here.", cleanItem->GetStackCount(), cleanItem->GetName());
     }
 }
weltall commented on 26.01.2009 15:10

committed a fix to svn

Project Manager
Lanarel commented on 24.02.2009 22:27

Any suggestion how to test this? Difficult to decide something that is not triggerable is not happening anymore. I suggest to close this once we have an idea that other things that might be influenced by this change are still working. Or if weltall is sure this is a good thing and we did not get any problems with this last month, he can close this as well.

weltall commented on 24.02.2009 23:47

it’s running on ezpcusa right now. i’m unsure if laanx has the fix yet. so only someone who plays normally in ezpcusa could tell it’s fixed (this bug is visible only with various people crafting/dropping items…)

Project Manager
Lanarel commented on 10.03.2009 22:33

Maybe tux_johny, Aiken, Elvors or Hitman can say if it stopped happening? Otherwise, if it did not introduce new errors (which it did not) and we do not get more reports for a while, I suggest closing this.

James commented on 11.03.2009 00:51

Checking 2 months of character logs for ezpcusa I can not find any ‘You probably should not leave’ messages. Have been mining and crafting.

Elvors Amenoras commented on 11.03.2009 08:09

I’m not mining enough anymore to say much about this.
Also, I’m not on Ezpcusa.
Can somebody confirm when this fix was installed on Laanx? If it was a week ago or more, I can confirm that it didn’t affect the intended functionality.

Mario Rohkrämer commented on 17.10.2009 10:35

About the first comment of Elvors: “Dresses of Queen Purrty (2)” is a title of a book.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing