PlaneShift

True.

Note: psCharacter::GetModeStr() will return "combat" if the character is in combat, "spell casting" if the character is casting a spell and so on … Simply adding the word "in" to the message (psWorkManager::HandleRepair()) will break all other cases.

Perhaps it would make sense to add the "in" to "combat" thusly "in combat" as the mode text.

or an if for the case if changing the mode with "in combat" breaks other messages…

You cannot repair anything because you are in battle ←- there and done.

From Peegs comment it would seem most logical to just use "fighting" as the mode word. so: "You cannot repair anything because you are combat fighting." It appears that the problem stems from the use of a static noun instead of an active verbal noun Combat is a thing that occurs but not something one is doing. Combatting would be correct, more or less but rather awkward. I suppose one really has to look at where and how else psCharacter::GetModeStr() is used.

Looking at the source code (revision 4111) I see const char * psCharacter::player_mode_to_str[] = {"unknown","peace","combat","spell casting","working","dead","sitting","carrying too much","exhausted", "defeated"}; This is an odd mix of nouns verbs and adjectives. I believe I misidentified the part of speech required, fighting would be a verb not a verbal noun. Peace and combat are the two nouns, In other places an adjective is appropriate such as "exhausted" or "defeated", "carrying too much" probably should be changed to "encumbered" if only for simplicity and consistency, dead has no alternative. Spell casting, working and sitting are the verbs that seem worth keeping.

I haven't look too much at how these are used specifically but these are some preliminary thoughts.

committed a fix