PlaneShift

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bug Report
  • Category
  • Assigned To No-one
  • Operating System
  • Severity Low
  • Priority
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: PlaneShift
Opened by Caarrie - 22.09.2008
Last edited by Steven Schwartfeger - 29.09.2008

FS#2266 - removal from guild message not accurate

If a member is removed from their guild the message is reported incorrectly, it says they left and not who removed them.

src/server/guildmanager.cpp:1463

if (targetClient != NULL)
    {
        psserver->SendSystemInfo(targetClient->GetClientNum(),"You have been removed from your guild.");
        UnsubscribeGuildData(targetClient);
 
        // forward blank MOTD to remove old
        csString blank("");
        csString motdMsg(psserver->GetMOTD());
        psMOTDMessage motd(targetClient->GetClientNum(),blank,motdMsg,blank,blank);
        motd.SendMessage();
    }
 
    csString text;
    text.Format("Player %s has left the guild.", (const char *)msg.player );
    psChatMessage guildmsg(0,"System",0,text,CHAT_GUILD, false);
    chatserver->SendGuild("server", gi, guildmsg);
 
    SendNotifications(gi->id, psGUIGuildMessage::MEMBER_DATA);

Idealy the message should be from the person that removed the player so that all know who did it.

Closed by  Steven Schwartfeger
29.09.2008 04:02
Reason for closing:  
Additional comments about closing:  

Tested.

weltall commented on 22.09.2008 22:05

commited a patch by caarrie and me to r2176

Caarrie commented on 22.09.2008 22:37

setting ready to test

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing