- Status Closed
- Percent Complete
- Task Type Bug Report
- Category
- Assigned To No-one
- Operating System
- Severity Medium
- Priority
- Reported Version
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
Attached to Project: PlaneShift
Opened by Hiker Hauk - 06.01.2009
Last edited by Caarrie - 06.01.2009
Opened by Hiker Hauk - 06.01.2009
Last edited by Caarrie - 06.01.2009
FS#2657 - Msg from psWorkManager::HandleCleanupEvent()
Issue:
While mining or crafting, you sometimes get surprising messages like, “You probably should not leave 1 pick here.” (I think this has been reported somewhere before? But I cannot find it. Anyway, there’s a possible fix below.)
Possible fix:
Well, at least the message is sent from here, in workmanager.cpp,
void psWorkManager::HandleCleanupEvent(psWorkGameEvent* workEvent)
{
#ifdef DEBUG_WORKMANAGER
CPrintf(CON_DEBUG, "handling cleanup workEvent...\n");
#endif
// Get event item
psItem* cleanItem = workEvent->GetTranformationItem();
if ( cleanItem )
{
cleanItem->SetGuardingCharacterID(0);
cleanItem->Save(true);
cleanItem->SetTransformationEvent(NULL);
//psserver->SendSystemOK(clientNum,"You probably should not leave %d %s here.", cleanItem->GetStackCount(), cleanItem->GetName());
// Hiker Hauk 20090106: Gets client num from the work event instead of from member variable
psserver->SendSystemOK(workEvent->client->GetClientNum(),"You probably should not leave %d %s here.", cleanItem->GetStackCount(), cleanItem->GetName());
}
}
Maybe someone who is more familiar with PS code or has access to the server can test it.
If this is not the case, the work event is corrupted at the source?
| ID | Project | Summary | Priority | Severity | Assigned To | Progress | |
|---|---|---|---|---|---|---|---|
| 1753 | PlaneShift | Medium |