- Status Closed
- Percent Complete
- Task Type Bug Report
- Category Engine → Inventory/Items
- Assigned To No-one
- Operating System
- Severity Medium
- Priority
- Reported Version
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
FS#2691 - Inventory cache becomes invalid when users do too many actions involving it
When the player does inventory actions too fast (e.g. buy potions)
due to UDP latencies the cash may invalidate (older cache state arrives after the valid one).
Talked with keith already. An solution approach would be cache versioning.
The server would update (increase) the cache version before it's sent to the client
and the client would simply drop packets with older version than the current.
Here is a patch for the technique described above (for PS trunk r2894).
I used udp tunneling to test this (got a 2000 ping) and it seems fixed (previous versions were dropped etc).
Patch is committed now. Testing team please test. The changes looked correct to me but I did not test it.
setting ready to test
Any hint on how to test this?
As I said above peeg:
Set up one or more udp tunnels and connect to your server through it(or them), trying to have as much ping as possible.
then, move items fast in your inventory, or buy something many times (fast as well). 500 ping is usually enough to get an invalid inventory,
but if you have e.g. 1000 ping, you'll probably get a hard time getting a valid inventory.
Test this on e.g. ezpcusa(stable) and then the patched client/server to see the difference.
Let's see about getting this one tested and closed?
rebuild ps on 2 cpus and had two clients open, so activating another window took seconds. Bought 124 door glyphs rapidly clicking buy. Amount of money gone and glyphs in inventory seemed to be OK. Closing