- Status Closed
- Percent Complete
- Task Type Bug Report
- Category Rules → Crafting Transformations
-
Assigned To
weltall - Operating System
- Severity Medium
- Priority
- Reported Version
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
Opened by Anonymous Submitter - 24.04.2009
Last edited by Lanarel - 19.11.2009
FS#2894 - Transform Matching
With no book in mind, place a molten iron in the forge and observe the following:
(17:06:28) >Checking single transforms for pattern id 0, target id 320, and target qty 1.
(17:06:28) >Found no transformations for item 320 and pattern 0.
(17:06:28) >Checking group transforms for pattern id 0, target id 320, and target qty 1.
(17:06:28) >Found no transformations for item 320 and pattern 0.
(17:06:28) >Checking patternless transforms for pattern id 0, target id 320, and target qty 1.
(17:06:28) >Found no transformations for item 320 and pattern 0.
(17:06:28) >Checking for any ingredient transforms for single pattern id 0 group pattern id 0, and target id 320.
(17:06:28) >No items for this pattern or group pattern.
(17:06:28) >Checking single any item transforms for pattern id 0, target id 0, and target qty 1.
(17:06:28) >Found 2 transformations.
(17:06:28) >Testing transformation id 1.
(17:06:28) >No match, transformation for wrong item candidate id=4800 workitem Id=4815.
(17:06:28) >Testing transformation id 15.
(17:06:28) >Good match for transformation id=15.
(17:06:28) >Scheduled to finish work on Molten Iron in 150.0 seconds.
Correct result except the first 6 lines show that the same exact thing was attempted 3 times.
Suggest put in an inital check for No Book In Mind and skip the first 2 and start with patternless.
With Working With Stock in mind, place a molten iron in the forge and observe the following:
(17:12:06) >Checking single transforms for pattern id 101, target id 320, and target qty 1.
(17:12:06) >Found 2 transformations.
(17:12:06) >Testing transformation id 1000.
(17:12:06) >No match, transformation for wrong item candidate id=321 workitem Id=4815.
(17:12:06) >Testing transformation id 1004.
(17:12:06) >No match, transformation for wrong item candidate id=321 workitem Id=4815.
(17:12:06) >Checking group transforms for pattern id 100, target id 320, and target qty 1.
(17:12:06) >Found no transformations for item 320 and pattern 100.
(17:12:06) >Checking patternless transforms for pattern id 0, target id 320, and target qty 1.
(17:12:06) >Found no transformations for item 320 and pattern 0.
(17:12:06) >Checking for any ingredient transforms for single pattern id 101 group pattern id 100, and target id 320.
(17:12:06) >No known transformations for this item.
(17:12:06) >Checking single any item transforms for pattern id 101, target id 0, and target qty 1.
(17:12:06) >Found no transformations for item 0 and pattern 101.
(17:12:06) >Checking group any item transforms for pattern id 100, target id 0, and target qty 1.
(17:12:06) >Found no transformations for item 0 and pattern 100.
(17:12:06) >You are not sure what to do with this.
What’s missing here from the previous example are the following:
* Checking for any ingredient transforms for single pattern id 0 group pattern id 0, and target id 320
* Checking single any item transforms for pattern id 0, target id 0, and target qty 1
Had the latter of these been checked, we’d have the same result as the example above.
The difference between these two are having a book in mind versus not, and that book being the wrong one for the task attempted.
| ID | Project | Summary | Priority | Severity | Assigned To | Progress | |
|---|---|---|---|---|---|---|---|
| 2656 | PlaneShift | FS#2656 - list of crafting bugs | Low | Davide Vescovini, Tuathanach |
19.11.2009 23:27
Reason for closing:
Additional comments about closing:
fixed by bovek
A bit different with svn trunk. Using Dough, Oven, and Catalog of Shields, first without anything in mind slot:
(23:00:59) >Checking single transforms for pattern id 0, target id 134, and target qty 1.
(23:00:59) >Found no transformations for item 134 and pattern 0.
(23:00:59) >Checking group transforms for pattern id 0, target id 134, and target qty 1.
(23:00:59) >Found no transformations for item 134 and pattern 0.
(23:00:59) >Checking patternless transforms for pattern id 0, target id 134, and target qty 1.
(23:00:59) >Found no transformations for item 134 and pattern 0.
(23:00:59) >Checking for any ingredient transforms for single pattern id 0 group pattern id 0, and target id 134.
(23:00:59) >No items for this pattern or group pattern.
(23:00:59) >Checking single any item transforms for pattern id 0, target id 0, and target qty 1.
(23:00:59) >Found 1 transformations.
(23:00:59) >Testing transformation id 19.
(23:00:59) >Good match for transformation id=19.
(23:00:59) >
(23:00:59) >Scheduled to finish work on Dough in 60.0 seconds.
(23:00:59) >
(23:00:59) >You are not sure what is going to happen to 1 Dough.
And then try with Catalog of Shields in mind slot; no output at all, and no transform even after waiting for far over 60 seconds.
Add both missing checks in the order indicated to the end of the sequence in the 2nd example of the original report.
Fixed on test server - please set Ready To Test
Tested and fixed.