- Status Closed
- Percent Complete
- Task Type Bug Report
- Category Engine → Pets
-
Assigned To
weltall Tucker G Tucos Jethare - Operating System
- Severity Medium
- Priority
- Reported Version
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
Attached to Project: PlaneShift
Opened by Orgonwukh - 02.07.2009
Last edited by aurelynt - 29.07.2009
Opened by Orgonwukh - 02.07.2009
Last edited by aurelynt - 29.07.2009
FS#3008 - Pet summon time not correct
“You are too weak to call your familiar to you any more today.” You get this message once your familiar automatically vanishes.
I received the message at 11 PM game’s time. When trying to summon the pet at the next game’s day 1 AM, the same message appeared.
It seems the time does not refer to the time in game. The message should be corrected so that it is clear when you can re-summon your pet.
Did not recheck, but this is definately what was the case for a long time :)
It's probably not time in game, but time you're logged on, just like the Death curse.
It is clear that that is what determines when the pet can be resummoned. The question here is, if the message given is wrong :)
Marking this a prospect task. Make sure to check with settings what the messages should read, and if the time you cannot summon it again should stay as long as 24 hours.
Ok, right now this gives 24 hours from the last use, this is too long. Instead make it so it is 240 minutes.
The message you get should be changed to "The power of the ring of familiar is currently depleted, it will take more time to summon a pet again."
– patch removed –
Two points:
Everywhere else you use upper case letters: 'Working with Stock', 'Book of Blades', 'Reinforced Battle Axe', … why not here?
Secondly, why not adding the time to wait into the string so e.g.: "The power of the Ring of Familiar is currently depleted, it will take 135 minutes to summon a pet again."?
The Capitals In Sentences is due to the fact that item names have capitals. It is not intended to be the normal way :). So that looks ok. I don't think using earth minutes is a good way to avoid talking of earth days :). So message looks good to me
Changed status to assigned, patch has been removed
Patch available at: http://pastebin.ca/1502889
boom! thanks tucos.
Tucos, please find someone to review this (weltall probably) and get it applied before it gets forgotten.
can someone try it from the testers please?
Tried it. Works as expected.
committed please test. @ tucos for the future do an svn diff from the branch root (in this case /trunk)
okay, sorry :) will change the other patches