- Status
- Percent Complete
- Task Type Bug Report
- Category Engine → Inventory/Items
-
Assigned To
Suilensh - Operating System
- Severity Medium
- Priority
- Reported Version
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
FS#3684 - NPCs don't accept split stacks traded
When an NPC wants more than one item, but you have the items in different slots (even containers, like when your inventory is full and you can’t easily make room for the full stack), the trade won’t complete, even if the total sum of all items traded is the right amount. It should not matter if you give an NPC a stack of 63 items or ten stacks of ten items plus one of three, or seven of nine( 
), etc..
Edit: they also don’t get given the items when they’re in the right amount but in different stacks / sacks in the inventory. One gets “You have to give manually, because you got too many items” instead. /Edit
| ID | Project | Summary | Priority | Severity | Assigned To | Progress | |
|---|---|---|---|---|---|---|---|
| 3845 | PlaneShift | Medium | Jay, Rizin, Angela, Ruaan | ||||
| 4522 | PlaneShift | Medium |
Confirmed.
Patch for part 2 of this bug: http://pastebin.ca/1732470
As for part 1, ExchangingCharacter::GetSimpleOffering() (which is used by PlayerToNPCExchange::HandleAccept()) doesn't coalesce split stacks. Checking to see if making it do so is a good idea, or if we need a more hackish fix somewhere else (presumably in PlayerToNPCExchange::HandleAccept()) (NOTE: we still need the patch for part 2 to avoid throwing up a bogus error message in the autogive case)
I just now got "You don't have too few Charmflower, come back when you have the right amount", while having a stack of 2 and a stack of 11, the quest wanting 4. Probably it didn't look beyond the first stack it encountered.
I don't think my patch got applied yet. Thanks for pointing out the buggy error message though, will throw a patch together straightaway.