- Status New
- Percent Complete
- Task Type Bug Report
- Category Engine → Character Creation
- Assigned To No-one
- Operating System
- Severity Medium
- Priority
- Reported Version
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
Attached to Project: PlaneShift
Opened by Ralph Campbell - 13.05.2011
Last edited by aurelynt - 15.05.2011
Opened by Ralph Campbell - 13.05.2011
Last edited by aurelynt - 15.05.2011
FS#5213 - don't hardcode race to set gender in pawscharcreatemain.cpp
Index: src/client/gui/pawscharcreatemain.cpp
— src/client/gui/pawscharcreatemain.cpp (revision 7252)
+++ src/client/gui/pawscharcreatemain.cpp (working copy)
@@ -1012,10 +1012,9 @@
view->Show(); view->EnableMouseControl(true);
- //temporary hardcoding needs removal
- maleButton→SetEnabled(id != 9);
- femaleButton→SetEnabled(id != 9);
- if(id==9)
+ maleButton→SetEnabled(currentGender != PSCHARACTER_GENDER_NONE);
+ femaleButton→SetEnabled(currentGender != PSCHARACTER_GENDER_NONE);
+ if (currentGender == PSCHARACTER_GENDER_NONE)
{
maleButton->SetState(false);
femaleButton->SetState(false);
Doesn't work: after selecting Kran as race in the character creation window, gender buttons can now be clicked, while they shouldn't (and they weren't before this change).
The problem lies deeper since setting the race (id) doesn't set a gender, that's why the test was made on the id before (9 for Kran) and not on the gender.
reverted for now