PlaneShift

/setskill me all 200?

that does not work if in events we need certain skills at certain lvls

What kind of event would that be? I can’t imagine a situation in a roleplaying event where your skill in sword making needs to be exactly 56 for the event to succeed. I’m not saying make a GUI for this would be bad, just that I don’t see how it would be more effective and really help events.

Besides, if you need a specific set of skills set before an event for some reason, you could always just make a shortcut beforehand. Or don’t multiple /setskill commands in a shortcut work? If so, that’d be a bug, but it’s known already.

With  FS#2324  and  FS#2378  I don’t think we need skills modifiable via GUI, at least not soon.
However, there came up a suggestion that should be taken into account. For testing and events, it might be good to easily set skills equally of a target like
/setskill me match harnquist
whereas the first argument is whose skills get set, “match” is keyword and second argument is the one whose skills get cloned.

Note: both arguments are regular “target”s

assigning to decker.
implement it like this /setskill [targetdestination] [targetorigin] copy
also /setskill [?argetdestination] copy [targetorigin] might work, probably even better

use targetdestination as a generic target but lock it to same target of issuer or put a validate call to a special permission used just for it to be extended to any target.

Here’s what I came up with (from svn diff). Although I’m not sure why you’re asking for a special permission check. There’s already a check in SetSkill to see if the client has “setskill others” access.

Index: src/server/adminmanager.cpp
===================================================================
--- src/server/adminmanager.cpp	(revision 4757)
+++ src/server/adminmanager.cpp	(working copy)
@@ -665,10 +665,15 @@
     {
         player = words[1];
         skill = words[2];
-        if (words.GetCount() >= 4)
+        if (words.GetCount() >= 4 && skill != "copy")
+        {
             value = words.GetInt(3);
+        }
         else
+        {
+            sourceplayer = words[3];
             value = -2;
+        }
         return true;
     }
     else if (command == "/set")
@@ -6518,11 +6523,47 @@
 
 void AdminManager::SetSkill(MsgEntry* me, psAdminCmdMessage& msg, AdminCmdData& data, Client* client, gemActor *target)
 {
-    if (data.skill.IsEmpty() || data.value == -2)
+    Client* sourceclient = NULL;
+    gemActor* source = NULL;
+    psCharacter * schar = NULL;
+
+    // Try to find the source of skills if we're doing a copy
+    if (data.skill == "copy")
     {
-        psserver->SendSystemError(me->clientnum, "Syntax: /setskill [target] [skill|'all'] [value|-1]");
-        return;
+        if (data.sourceplayer == "me")
+        {
+            sourceclient = client;
+        }
+        else
+        {
+            sourceclient = FindPlayerClient(data.sourceplayer);
+        }
+
+        if (sourceclient)
+        {
+            source = sourceclient->GetActor();
+            schar = source->GetCharacterData();
+            if (!schar)
+            {
+                psserver->SendSystemError(me->clientnum, "No source character data!");
+                return;
+            }
+        }
+        else
+        {
+            psserver->SendSystemError(me->clientnum, "Syntax: /setskill [target] [skill|'all'] [value|-1] | [target] copy [source]");
+            return;
+        }
     }
+    // Otherwise just proceed as normal
+    else
+    {
+        if (data.skill.IsEmpty() || data.value == -2)
+        {
+            psserver->SendSystemError(me->clientnum, "Syntax: jurg jurg jurg /setskill [target] [skill|'all'] [value|-1] | [target] copy [source]");
+            return;
+        }
+    }
 
     if (target == NULL)
     {
@@ -6603,6 +6644,26 @@
             psserver->SendSystemOK(target->GetClientID(), "All your skills were set to %d by a GM", data.value);
         }
     }
+    else if (data.skill == "copy")
+    {
+        for (int i=0; i<PSSKILL_COUNT; i++)
+        {
+            psSkillInfo * skill = CacheManager::GetSingleton().GetSkillByID(i);
+            if (skill == NULL) continue;
+
+            unsigned int old_value = pchar->Skills().GetSkillRank(skill->id).Current();
+            unsigned int new_value = schar->Skills().GetSkillRank(skill->id).Current();
+
+            pchar->SetSkillRank(skill->id, new_value);
+            psserver->SendSystemInfo(me->clientnum, "Changed '%s' of '%s' from %u to %u", skill->name.GetDataSafe(), target->GetName(), old_value, new_value);
+
+            if (target->GetClient() &&  target->GetClient() != client)
+            {
+                // Inform the other player.
+                psserver->SendSystemOK(target->GetClientID(), "Your '%s' level was set to %d by a GM", data.skill.GetDataSafe(), new_value);
+            }
+        }
+    }
     else
     {
         psSkillInfo * skill = CacheManager::GetSingleton().GetSkillByName(data.skill);

Gah! Is there no way to attach files then? the <code> junk didn’t seem to work too well.

Diffs are here:
http://pastebin.ca/1681781 http://pastebin.ca/1681783

Messed up some indentation in adminmanager.cpp. Here’s a fixed up diff:
http://pastebin.ca/1681795

1) you can do a single diff for both the files
2) you should search also with findobjectbystring (and then check you got an actor) else it’s not possible to use pids or eids

All set:
http://pastebin.ca/1682699

committed look ok

works fine. “/setskill me copy someplayer” set most of my skills to 0, and some to different values.