Author Topic: Help request: Bug #519 - ingame editing of Keyboard Shortcut Keys  (Read 1991 times)

acraig

  • Administrator
  • Veteran
  • *
  • Posts: 1562
    • View Profile
This seemed to work pretty well before. So I will try another :)

Bug 519

I cannot seem to duplicate this.  It seems from the report that a different keys.xml file will crash the client.  Here\'s what I did to test:

1) Start client
2) Go to options->control-keyboard
3) Scroll down to shortcuts and set a keyboard shortcut.
4) Save and quit client
5) Start up client again
6) Check that shortcut key still works.


Any help in testing this would be appreciated.
----------
Andrew
"For all I know, she's lying, everyone's lying; welcome to the Internet"

mikewsnc

  • Hydlaa Citizen
  • *
  • Posts: 217
    • View Profile
(No subject)
« Reply #1 on: April 04, 2005, 06:09:48 am »
I had no problem to report. Seems to be working fine.

Aranis
Only sacrifice will bring true reward.

Kosh_Dukai

  • Traveller
  • *
  • Posts: 35
    • View Profile
(No subject)
« Reply #2 on: April 04, 2005, 06:34:55 pm »
At 1st, this was happening on my laptop (V.0.3.009 but one update behind, still with the Red Target Mark working, etc) so I didn\'t mind these crashes after figuring out what was the cause if it.

I only reported this bug after using another PC with a fully upgraded version. Last update was made on 2005.04.03 on a V.0.3.009 psclient, of course, although there was nothing to be updated, besides the update*.txt file (can\'t remember the correct file name).

One thing I\'d like to ask about the added lines after setting three keyboard shortcuts then Save, play a bit and then Quit:
(btw, these are the lines that, if deleted from .\\data\\options\\keys.xml, psclient won\'t crash after login screen)





Is the \"shortcutcmd##\" value a valid one ?

If so, what\'s the use of the default lines (already present on .\\data\\options\\keys.xml) ?












Anyway, I\'ll try this on my other 2 PCs with PS installed. If these two other have the same exact problem, I\'ll pick one, uninstall PS and reinstall from the currently available win32 installer of V.0.3.009 and try to reproduce this bug again.

Maybe something got weirdly wrong with all my PS installations, \'cause my last clean install was made with 0.3.004 if I\'m not mistaken, and from then on, all was kept up to date through updater.exe.

EDIT: I remember using in the past versions the Options>Keyboard>Shortcut Keys>Save and all worked fine. I simply can\'t say since what version it started to have this behaviour, because I didn\'t need Shortcut Keys for a while until needing it again now.
« Last Edit: April 04, 2005, 06:43:49 pm by Kosh_Dukai »

Nikodemus

  • Prospects
  • Veteran
  • *
  • Posts: 1808
    • View Profile
(No subject)
« Reply #3 on: April 04, 2005, 07:57:46 pm »
I have just set (saved them)  few key shortcuts as you said Acraig
quited, reloged
all the shortcuts were working fine without any crash

as for the \",\" nd \".\" which i have set as key shortcuts for next and previous item. Everythink is working fine without crash here.

As for the lines:











After i deleted them i could finally set 1,2,3,4,5,6,7,8,9,0 keys for my defined shortcuts ;) before the above lines deletions i could set the keys but these were not working.

Also i would like to ask dev team to make the num1-0 and normal1-0 keys not be the same. Now when i set \"1\" for /dig for gold whe automaticaly \"num1\" will do the same.
I would like to be able to set \"1-0\" keys for somethink and at the same time have \"num1-0\" set for some other action.

Thank you in advence ;)



What you can failure tommorow, failure today.


Better click for shiny stylez Help me with images!

Kosh_Dukai

  • Traveller
  • *
  • Posts: 35
    • View Profile
(No subject)
« Reply #4 on: April 04, 2005, 09:09:44 pm »
Yup, this time I tried to define keys \"0\" to \"9\" and couldn\'t use them ingame. So, that \"shortcut##\" block is the responsible for that \"unusable numeric keys\" problem :)

Anyway, about Bug#519 (and Bug#509), I think the problem is the \"-\" char on this line:




I\'m doing some tests right now and post the result asap.

Kosh_Dukai

  • Traveller
  • *
  • Posts: 35
    • View Profile
(No subject)
« Reply #5 on: April 04, 2005, 09:58:37 pm »
Yup, just tested it.

This line makes psclient crash:



So it looks like a XML parsing problem with \"-\"

I think the distinction of 0-9 and num0-num9 is a useful idea :)
« Last Edit: April 04, 2005, 10:04:45 pm by Kosh_Dukai »

Nikodemus

  • Prospects
  • Veteran
  • *
  • Posts: 1808
    • View Profile
(No subject)
« Reply #6 on: April 05, 2005, 03:02:35 pm »
I have forgotten to say that the default 30 shortcuts buttons are not enough for me and i dont know how to add them more. would be great if everybody would have possibility to add as many buttons as they want.



What you can failure tommorow, failure today.


Better click for shiny stylez Help me with images!

Burntleaf

  • Hydlaa Resident
  • *
  • Posts: 79
    • View Profile
(No subject)
« Reply #7 on: April 05, 2005, 03:11:05 pm »
well.. there are over 70 keys on thee keyboard so...
Charly said always tell your mummy before you\'re going somewhere- Charly- The Prodigy

Kosh_Dukai

  • Traveller
  • *
  • Posts: 35
    • View Profile
(No subject)
« Reply #8 on: April 05, 2005, 06:04:17 pm »
Currently, for me, 30 is enough but I wouldn\'t mind seeing more shortcut slots available.

I can imagine a PS installation shared by more than one person, where, each player wants his own settings, including his own shortcuts and keys.

So, unless psclient starts keeping player settings on a *per player* way as opposed to the current global way, I see the usefullness of more (at least) shortcut slots so there\'s plenty for each player favorite shortcut definitions.

One quick \"dirty\" external hack would be to start psclient through a batch/script file that would accept a $player arg doing something like:
1) copy from ./PlayerSettings/${player}/data/options/*.xml to ./data/options/
2) start psclient
3) copy all ./data/options/* back to ./PlayerSettings/${player}/data/options/

I already tested this on one of my PCs and it works :)
I\'ve included the ./planeshift.cfg file and made it so it only keeps track of some but not all *.xml files. Only the usefull to be kept \"per player\" letting the others stay as \"global\".

It\'s not a nice solution though, but it works if one needs such a setup.
It would be nice to see in the future an \"official\" solution for multi per-player settings on such things as keyboard mapping, shortcuts definitions and window state/size/positions, etc...


errr... btw, since I\'m touching this subject :>

I miss $vars on shortcut definitions. So something like /target $me would be possible.

If no $vars are planned, then at least a /target_me or equivalent command would be nice.

This would let me do a more general version of:
/target Koshdukai; /cast defensive wind; /target_nearest_next_npc

with something like:
x=$target; /target $me; /cast defensive wind; /target $x
*or*
/target_me; /cast defensive wind; /target_previous (if any)

hmmm... one other usefull addition would be an /alias system (as in *nix shell) but the shortcut slots are an already usefull resource anyway.

*phew*... enough almost-off-topic for now ;P

Nikodemus

  • Prospects
  • Veteran
  • *
  • Posts: 1808
    • View Profile
(No subject)
« Reply #9 on: April 06, 2005, 12:09:44 am »
I haven\'t in mind support for different users at the same client ;) I just said the default 30 shortcut buttons are not enough to set all commands what i want:
all the commands for selling, buying, training, greeting targeting previous/next npc/item/player all the spells, mining different ores. equiping/dequiping weapons/tools.
Simply, when now 30 buttons are not enough, what later, when there will be more spells and minerals to dig.

And command for targetting myself fe \"/target_me\" would be really usefull for casting defensive wind and rocky armor.
Good idea Kosh_Dukai.
« Last Edit: April 06, 2005, 12:13:49 am by Nikodemus »



What you can failure tommorow, failure today.


Better click for shiny stylez Help me with images!

acraig

  • Administrator
  • Veteran
  • *
  • Posts: 1562
    • View Profile
(No subject)
« Reply #10 on: April 06, 2005, 03:00:16 am »
This was a bug in Crystal Space and will be fixed whenever a new client is released.  Currently this bug will cause your client to crash if you have a + or a - as a shortcut key.  So if you have one of those in your keys.xml and a crashing client then remove it.  Thanks to those that helped test this bug.
----------
Andrew
"For all I know, she's lying, everyone's lying; welcome to the Internet"