Author Topic: longstanding bug  (Read 350 times)

JeroMiya

  • Traveller
  • *
  • Posts: 33
    • View Profile
longstanding bug
« on: June 15, 2005, 08:11:38 am »
hehe I\'ve posted this error before but I guess noone seems to care about an error that only occurs on mac builds. I\'m surprised dyfrer or chaos haven\'t complained about it and had someone commit a fix, it\'s really just a very simple error:

The error is on src/updater/updaterconfig.cpp:392

It should be changed to:
#ifdef CS_PLATFORM_WIN32
        modules.Push(\"win32\");
#elif defined(CS_PLATFORM_MACOSX)
        modules.Push(\"macosx\");
#else
        modules.Push(\"other_os\");
#endif

since CS_PLATFORM_MACOSX is simply defined, it is a blank macro and not a boolean value.

Cha0s

  • Veteran
  • *
  • Posts: 1860
    • View Profile
(No subject)
« Reply #1 on: June 15, 2005, 11:45:11 am »
Heh. Thanks for the report, but I don\'t read the config files on a regular basis, you know. :P

I\'m sure dfryer will take a look at it and correct the issue in the next build. I think he has to worry about the crashes first, though. ;)
« Last Edit: June 15, 2005, 11:45:27 am by Cha0s »
Cha0s
Mac OS X Forum Moderator
In-Game Roleplay Forum Moderator
Please search and skim existing threads before posting!

dfryer

  • Veteran
  • *
  • Posts: 1070
    • View Profile
(No subject)
« Reply #2 on: June 16, 2005, 12:55:58 am »
Heh, I think I have it modified in a local copy *whistles innocently*

Every once in a while I carefully merge small hacks into the main source tree..
Quidquid latine dictum sit, altum sonatur.