Author Topic: Please test the configurable chat window  (Read 2573 times)

Bereror

  • Hydlaa Notable
  • *
  • Posts: 773
    • View Profile
    • Planeshift API
Please test the configurable chat window
« on: October 14, 2006, 07:28:31 pm »
People with clients built from sources can test the configurable chat window with modified sources from here: Chat window sources.

Please let me know if you find something that still doesn't work before I commit changes to the CVS repository.
PlaneShift Sources
PlaneShift API
"Words never spoken
Are the strongest resounding"

Verrliit

  • Hydlaa Citizen
  • *
  • Posts: 244
    • View Profile
Re: Please test the configurable chat window
« Reply #1 on: October 14, 2006, 09:06:48 pm »
Oooohh, you have invented a cure for the terrible blindness?

Verrliit pounce-huggles Bereror, purring loudly...

You are just wonderful...

Thank you.


(Now would someone host torrents for compiled versions, pretty please?)


~Verrliit~
The Devs have invited us to play in their sandbox. The GMs keep us from spoiling each other's fun.  Be respectful, and thank them often.



Courtesy cannot be imposed by force.  Lead by example.  Be elegant.  - Dr. H. Lecter

Lanarel

  • Testers
  • Hydlaa Notable
  • *
  • Posts: 782
    • View Profile
Re: Please test the configurable chat window
« Reply #2 on: October 15, 2006, 01:47:24 am »
I did a quick test (few weeks old CVS). I tested mainly chat, npc chat, system messages from greeting, fighting, advising. No tells/guild/group. In general it seems to work as I imagine the idea is. Text appears in the main and original tab for the selected choices. Tabs flash only when selected to do so. The only thing I noticed that is not correct is the following:
If you target an NPC and type text in the main tab, the NPC does not hear you (as I would expect). Typing in the NPC type makes the NPC hear you. However, if you direct NPC text to the main tab, this tab is activated when the NPC answers you. If you then want to talk back, you have to first select the NPC tab again. I do not think this is intended behaviour.

I understand this is an 'easy' client side fix, so people can direct everything to one tab, and stop the flashing. I think it would be even nicer if the flashing was a bit smarter though. I would like a tab to flash if it shows me there is new information there, that I did not see yet in the active tab, and only flash in one of the tabs. I cannot do that yet with the new flash options. For example, if I redirect system messages to main, and I am in main, I do not want to see system tab flashing when someone greets. However, when I am in the tell tab, and someone greets, I would want the system tab to flash (but not the main also as in the current official client). Just an extra wish to be ignored :) Good job on getting the tabs somewhat configurable anyway  \\o//



Karyuu

  • Forum Legend
  • *
  • Posts: 9341
    • View Profile
Re: Please test the configurable chat window
« Reply #3 on: October 15, 2006, 02:03:34 am »
If I may make a suggestion for flashing:

Changing the color of a tab or tab text instead of blinking would be a big relief. Blinking can be very distracting when you are engaged in something, while a simple color change (from white to red for example) would be easier on the eyes.
Judge: Are you trying to show contempt for this court, Mr Smith?
Smith: No, My Lord. I am attempting to conceal it.

Bereror

  • Hydlaa Notable
  • *
  • Posts: 773
    • View Profile
    • Planeshift API
Re: Please test the configurable chat window
« Reply #4 on: October 15, 2006, 12:00:57 pm »
If you target an NPC and type text in the main tab, the NPC does not hear you (as I would expect). Typing in the NPC type makes the NPC hear you. However, if you direct NPC text to the main tab, this tab is activated when the NPC answers you. If you then want to talk back, you have to first select the NPC tab again. I do not think this is intended behaviour.

To talk to the NPC on the main tab, you need to prefix it with the /tellnpc command like you would be with tells, guild and group chat. If you are on the NPC tab, then the system adds the /tellnpc command automatically like it also does on guild and group tabs, so it is an intended behavior.

I understand this is an 'easy' client side fix, so people can direct everything to one tab, and stop the flashing. I think it would be even nicer if the flashing was a bit smarter though. I would like a tab to flash if it shows me there is new information there, that I did not see yet in the active tab, and only flash in one of the tabs. I cannot do that yet with the new flash options. For example, if I redirect system messages to main, and I am in main, I do not want to see system tab flashing when someone greets. However, when I am in the tell tab, and someone greets, I would want the system tab to flash (but not the main also as in the current official client). Just an extra wish to be ignored :) Good job on getting the tabs somewhat configurable anyway  \\o//

Flashing should be actually working the way how you are describing here. If you redirect tells to the main tab, then they will be shown both on the main tab and on the tells tab. If you are already on one of these tabs, no tabs should be flashing. If you are on any other tabs, only the main tab should be flashing. Main tab and not the tells tab, because by redirecting tells to the main tab you probably wanted to read them there.

Changing the color of a tab or tab text instead of blinking would be a big relief. Blinking can be very distracting when you are engaged in something, while a simple color change (from white to red for example) would be easier on the eyes.

Should be possible. I will make a test and see, how well does it work.
PlaneShift Sources
PlaneShift API
"Words never spoken
Are the strongest resounding"

Croconil

  • Hydlaa Notable
  • *
  • Posts: 642
  • <3 Peacer!
    • View Profile
    • Talk Box
Re: Please test the configurable chat window
« Reply #5 on: October 15, 2006, 04:01:13 pm »
If I may make a suggestion for flashing:

Changing the color of a tab or tab text instead of blinking would be a big relief. Blinking can be very distracting when you are engaged in something, while a simple color change (from white to red for example) would be easier on the eyes.

Nice suggestion Kary. That would be alot better than the constant blinking.

* Croconil bows and shouts "All hail Bereror! The bringer of the custom chat window!"

Hassadria

  • Traveller
  • *
  • Posts: 14
    • View Profile
Re: Please test the configurable chat window
« Reply #6 on: October 15, 2006, 04:31:53 pm »
Changing the color of a tab or tab text instead of blinking would be a big relief. Blinking can be very distracting when you are engaged in something, while a simple color change (from white to red for example) would be easier on the eyes.

Should be possible. I will make a test and see, how well does it work.


I already did something like this, but my solution disables flashing completely. It replaces it by a new background for the buttons.
If interested, have a look here:
Edit: Link removed

Inside is a patch for the source of 0.3.016 cvs (latest history.txt entry 2006-09-17) in diff-format and some files I changed or added to the elven skin.
Also a small screenshot is included.
« Last Edit: October 21, 2006, 04:17:03 pm by Hassadria »

Lanarel

  • Testers
  • Hydlaa Notable
  • *
  • Posts: 782
    • View Profile
Re: Please test the configurable chat window
« Reply #7 on: October 15, 2006, 11:35:53 pm »
...
I would like a tab to flash if it shows me there is new information there, that I did not see yet in the active tab, and only flash in one of the tabs.
...

Flashing should be actually working the way how you are describing here. If you redirect tells to the main tab, then they will be shown both on the main tab and on the tells tab. If you are already on one of these tabs, no tabs should be flashing. If you are on any other tabs, only the main tab should be flashing. Main tab and not the tells tab, because by redirecting tells to the main tab you probably wanted to read them there.
I just checked again, and you are right, it works!  \\o// I should not do half tests in the middle of the night :)

If you target an NPC and type text in the main tab, the NPC does not hear you (as I would expect). Typing in the NPC type makes the NPC hear you. However, if you direct NPC text to the main tab, this tab is activated when the NPC answers you. If you then want to talk back, you have to first select the NPC tab again. I do not think this is intended behaviour.

To talk to the NPC on the main tab, you need to prefix it with the /tellnpc command like you would be with tells, guild and group chat. If you are on the NPC tab, then the system adds the /tellnpc command automatically like it also does on guild and group tabs, so it is an intended behavior.

I know about /tellnpc, and it is not what I meant. Or maybe it is: I do not like to type that everytime, that is why I have conversations with NPCs in the NPC tab. However, when I redirect NPC chat to the main tab, everytime an NPC answers me, the main tab is activated again. I now found out this also works with tell. For example, I am in any tab but main (for example tell) and I do '/tell lanarel hello' and it will activate the main tab (if tells are redirected). I cannot imagine that this is what you intended.  It would mean that if I want to see tells in main, but have conversations in the tell tab as well, I cannot do that. I hope I was clear this time :)

Bereror

  • Hydlaa Notable
  • *
  • Posts: 773
    • View Profile
    • Planeshift API
Re: Please test the configurable chat window
« Reply #8 on: October 16, 2006, 07:48:34 am »
I know about /tellnpc, and it is not what I meant. Or maybe it is: I do not like to type that everytime, that is why I have conversations with NPCs in the NPC tab. However, when I redirect NPC chat to the main tab, everytime an NPC answers me, the main tab is activated again. I now found out this also works with tell. For example, I am in any tab but main (for example tell) and I do '/tell lanarel hello' and it will activate the main tab (if tells are redirected). I cannot imagine that this is what you intended.  It would mean that if I want to see tells in main, but have conversations in the tell tab as well, I cannot do that. I hope I was clear this time :)

If you look at the Options -> Interface -> Chat page, you will find "Select fitting Tab" and "Select Main Tab" options. They can be used to change, which tabs are selected.

For example, if you have tells redirected to the Main tab, then the expected behavior is the following:

A) You are already on the Main tab or on the Tells tab -- nothing will change and you stay on the tab were you are.

B) You are on any other tabs:
* With the "Select Main Tab" option enabled, the Main tab is selected;
* With the "Select fitting Tab" option, the Tells tab is selected.
PlaneShift Sources
PlaneShift API
"Words never spoken
Are the strongest resounding"

Lanarel

  • Testers
  • Hydlaa Notable
  • *
  • Posts: 782
    • View Profile
Re: Please test the configurable chat window
« Reply #9 on: October 16, 2006, 09:47:53 pm »
If you look at the Options -> Interface -> Chat page, you will find "Select fitting Tab" and "Select Main Tab" options. They can be used to change, which tabs are selected.

For example, if you have tells redirected to the Main tab, then the expected behavior is the following:

A) You are already on the Main tab or on the Tells tab -- nothing will change and you stay on the tab were you are.

B) You are on any other tabs:
* With the "Select Main Tab" option enabled, the Main tab is selected;
* With the "Select fitting Tab" option, the Tells tab is selected.


Never saw those settings :) They are quite handy to switch off the wrong behaviour. Also, after testing until I almost got muted for spamming myself, I found that I was wrong about tell not working as you described. It works exactly like that.  :oops:

The NPC tab  however does not. In a similar situation to A, when I am in the NPC tab and an NPC talks to me, focus switches to the main tab when "select Main Tab" is enabled, as if the situation were B. It does not recognise the NPC tab as a correct tab for NPC talk.

Bereror

  • Hydlaa Notable
  • *
  • Posts: 773
    • View Profile
    • Planeshift API
Re: Please test the configurable chat window
« Reply #10 on: October 16, 2006, 10:30:38 pm »
The NPC tab  however does not. In a similar situation to A, when I am in the NPC tab and an NPC talks to me, focus switches to the main tab when "select Main Tab" is enabled, as if the situation were B. It does not recognise the NPC tab as a correct tab for NPC talk.

Thanks for testing and finding that bug :) The NPC chat widget is called "NpcText", but I tried to find a widget called "NPCText". Sometimes it makes a big difference :P
PlaneShift Sources
PlaneShift API
"Words never spoken
Are the strongest resounding"

Uyaem

  • Hydlaa Notable
  • *
  • Posts: 747
    • View Profile
Re: Please test the configurable chat window
« Reply #11 on: October 19, 2006, 04:59:15 pm »
Tried it out too, seemed to work nicely except for the smaller issues already mentioned. Very nice, thanks! :D
The internet is "the terrorists'" most important weapon, they say.
Wrong.
Fear is their most important weapon.
Ours is our freedom.