Author Topic: SB installer change that broke XFire's PS support  (Read 2082 times)

kaerli2

  • Hydlaa Resident
  • *
  • Posts: 163
    • View Profile
SB installer change that broke XFire's PS support
« on: January 06, 2009, 03:36:03 am »
Linux and Mac people can safely ignore this.

The Windows installers for all the Crystal Blue releases stuffed their uninstall information into HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\PlaneShift\.  XFire needs to know the path to the game executable for each and every game (including our beloved PlaneShift) that it supports, so it looks in the Registry, in a place governed by its INI file (xfire_games.ini for those unfamiliar).  In PlaneShift's case, the aforementioned key (in fact, its UninstallString subkey) is what XFire picks that path up from.

Fast forward to Steel Blue.  When the first (0.4.00) Windows SB installer was made, somebody thought it was a bright idea to change the uninstall key to HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\PlaneShift <insert PS version here>\.   :oops:  This not only broke XFire support and continues to break it (and must be dealt with if we want XFire support again), but leaves garbage behind in the Registry whenever a new version (0.4.01 say) is installed atop an old one.

Summary: the 0.4.04 installer should change the uninstall key's name to not include the version number, unless there's an extremely good reason for it to be there.  :detective:

Caarrie

  • Forum Addict
  • *
  • Posts: 3369
  • We want no UNFIXED bugs!!!!!!!!!!!!!
    • View Profile
    • PlaneShift3dMods
Re: SB installer change that broke XFire's PS support
« Reply #1 on: January 06, 2009, 03:38:41 am »
how about ps does not care about xfire or support for other apps outside the ps tree, we changed installers for the SB release and that might have an effect on this. I dont see the devs changing this for those that want to use outside apps in ps.

kaerli2

  • Hydlaa Resident
  • *
  • Posts: 163
    • View Profile
Re: SB installer change that broke XFire's PS support
« Reply #2 on: January 06, 2009, 04:05:13 am »
Caarrie: XFire can't do a thing about this on their end as there are no wildcards for Registry keys.  Also, it isn't a good idea to leave garbage laying around in the Registry whenever people install a new PS release, k?

Vengeance

  • Veteran
  • *
  • Posts: 1452
    • View Profile
Re: SB installer change that broke XFire's PS support
« Reply #3 on: January 08, 2009, 03:26:17 am »
Seems reasonable to me to change it back.  PM Xordan with a link to this thread.  He maintains the installer I believe.